Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7868)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2497113002: MD Settings: Cleanup ifdefs when registering localized strings. (Closed)
Patch Set: Nit. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index caec04d0e44c33c173d47df6bc9051e67ed0ac5e..13bcfe07774fee5ae1a8b3e4cc4011896f87ec07 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -1745,40 +1745,13 @@ void AddCrNetworkStrings(content::WebUIDataSource* html_source) {
void AddLocalizedStrings(content::WebUIDataSource* html_source,
Profile* profile) {
- AddCommonStrings(html_source, profile);
-
AddA11yStrings(html_source);
AddAboutStrings(html_source);
-#if defined(OS_CHROMEOS)
- AddAccountUITweaksStrings(html_source, profile);
-#endif
AddAppearanceStrings(html_source, profile);
-#if defined(OS_CHROMEOS)
- AddBluetoothStrings(html_source);
-#endif
-#if defined(USE_NSS_CERTS)
- AddCertificateManagerStrings(html_source);
-#endif
AddClearBrowsingDataStrings(html_source);
-#if !defined(OS_CHROMEOS)
- AddDefaultBrowserStrings(html_source);
-#endif
-#if defined(OS_CHROMEOS)
- AddDateTimeStrings(html_source);
- AddDeviceStrings(html_source);
-#endif
+ AddCommonStrings(html_source, profile);
AddDownloadsStrings(html_source);
-
-#if defined(OS_CHROMEOS)
- AddEasyUnlockStrings(html_source);
- AddImportDataStrings(html_source);
- AddInternetStrings(html_source);
- AddCrNetworkStrings(html_source);
-#endif
AddLanguagesStrings(html_source);
-#if defined(OS_CHROMEOS)
- AddMultiProfilesStrings(html_source, profile);
-#endif
AddOnStartupStrings(html_source);
AddPasswordsAndFormsStrings(html_source);
AddPeopleStrings(html_source);
@@ -1789,12 +1762,28 @@ void AddLocalizedStrings(content::WebUIDataSource* html_source,
AddSearchInSettingsStrings(html_source);
AddSearchStrings(html_source);
AddSiteSettingsStrings(html_source, profile);
-#if !defined(OS_CHROMEOS)
- AddSystemStrings(html_source);
-#endif
AddUsersStrings(html_source);
AddWebContentStrings(html_source);
+#if defined(OS_CHROMEOS)
+ AddAccountUITweaksStrings(html_source, profile);
+ AddBluetoothStrings(html_source);
+ AddCrNetworkStrings(html_source);
+ AddDateTimeStrings(html_source);
+ AddDeviceStrings(html_source);
+ AddEasyUnlockStrings(html_source);
+ AddImportDataStrings(html_source);
+ AddInternetStrings(html_source);
+ AddMultiProfilesStrings(html_source, profile);
+#else
+ AddSystemStrings(html_source);
+ AddDefaultBrowserStrings(html_source);
+#endif
+
+#if defined(USE_NSS_CERTS)
+ AddCertificateManagerStrings(html_source);
+#endif
+
policy_indicator::AddLocalizedStrings(html_source);
html_source->SetJsonPath(kLocalizedStringsFile);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698