Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2497073002: Revert of Fix RenderWidgetHostViewMac compliance with NSTextInputClient. (Closed)

Created:
4 years, 1 month ago by erikchen
Modified:
4 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix RenderWidgetHostViewMac compliance with NSTextInputClient. (patchset #2 id:20001 of https://codereview.chromium.org/2480893002/ ) Reason for revert: Breaks some IME [hold down a vowel, English input language] without fully fixing IME issues on macOS Sierra. https://bugs.chromium.org/p/chromium/issues/detail?id=664554#c5 Original issue's description: > Fix memory leaks in macOS Sierra for IME. > > The documentation for NSTextInputClient states that: > -selectedRange should return { NSNotFound, 0 } if there is no selection range. > -attributedSubstringForProposedRange:actualRange: must be able to handle > invalid ranges. > > The previous implementations in RenderWidgetHostViewCocoa failed to do either, > which results in catastrophic memory leaks on macOS Sierra during IME. In an > ASAN build, AppKit attempts to allocate ~2^64 bytes of memory. > > BUG=654695 > > Committed: https://crrev.com/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5 > Cr-Commit-Position: refs/heads/master@{#430116} TBR=avi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=654695 Committed: https://crrev.com/f31b9cbfe43d85c9b631c1da8a01997b9ef24e9c Cr-Commit-Position: refs/heads/master@{#431713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -46 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +5 lines, -23 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
Created Revert of Fix RenderWidgetHostViewMac compliance with NSTextInputClient.
4 years, 1 month ago (2016-11-12 00:09:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497073002/1
4 years, 1 month ago (2016-11-12 00:09:40 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-12 00:35:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-12 00:48:04 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 00:49:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f31b9cbfe43d85c9b631c1da8a01997b9ef24e9c
Cr-Commit-Position: refs/heads/master@{#431713}

Powered by Google App Engine
This is Rietveld 408576698