Chromium Code Reviews
DescriptionRevert of Fix RenderWidgetHostViewMac compliance with NSTextInputClient. (patchset #2 id:20001 of https://codereview.chromium.org/2480893002/ )
Reason for revert:
Breaks some IME [hold down a vowel, English input language] without fully fixing IME issues on macOS Sierra.
https://bugs.chromium.org/p/chromium/issues/detail?id=664554#c5
Original issue's description:
> Fix memory leaks in macOS Sierra for IME.
>
> The documentation for NSTextInputClient states that:
> -selectedRange should return { NSNotFound, 0 } if there is no selection range.
> -attributedSubstringForProposedRange:actualRange: must be able to handle
> invalid ranges.
>
> The previous implementations in RenderWidgetHostViewCocoa failed to do either,
> which results in catastrophic memory leaks on macOS Sierra during IME. In an
> ASAN build, AppKit attempts to allocate ~2^64 bytes of memory.
>
> BUG=654695
>
> Committed: https://crrev.com/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5
> Cr-Commit-Position: refs/heads/master@{#430116}
TBR=avi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654695
Committed: https://crrev.com/f31b9cbfe43d85c9b631c1da8a01997b9ef24e9c
Cr-Commit-Position: refs/heads/master@{#431713}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
||||||||||||||||||||||||||||