tools/perf/page_sets/system_health/browsing_stories.py - Issue 2497023002: [SystemHealth] Wait for element to exist before trying to scroll to it in browsing stories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2497023002: [SystemHealth] Wait for element to exist before trying to scroll to it in browsing stories. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/system_health/browsing_stories.py

diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py

index f8527e0634736fc3f57a5fc87f13e51b531ebfa8..27c577deed0b635331a29d8f8820f003582293de 100644

--- a/tools/perf/page_sets/system_health/browsing_stories.py

+++ b/tools/perf/page_sets/system_health/browsing_stories.py

@@ -30,6 +30,7 @@ class _BrowsingStory(system_health_story.SystemHealthStory):

item_selector = 'document.querySelectorAll("%s")[%d]' % (

self.ITEM_SELECTOR, index)

# Only scrolls if element is not currently in viewport.

+ action_runner.WaitForElement(element_function=item_selector)

action_runner.ScrollPageToElement(element_function=item_selector)

self._ClickLink(action_runner, item_selector)

« no previous file with comments | « no previous file | no next file » | no next file with comments »