Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2496983002: Add default constructor and operator==/!= for CullRect (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add default constructor and operator==/!= for CullRect This is split from https://codereview.chromium.org/2430313004/ BUG=663208 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/36883fc1dd5c53c5dbcb57b9209d1be001df80ee Cr-Commit-Position: refs/heads/master@{#431661}

Patch Set 1 #

Total comments: 2

Patch Set 2 : - #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/CullRect.h View 1 3 chunks +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
Xianzhu
4 years, 1 month ago (2016-11-11 18:14:48 UTC) #4
chrishtr
https://codereview.chromium.org/2496983002/diff/1/third_party/WebKit/Source/platform/graphics/paint/CullRect.h File third_party/WebKit/Source/platform/graphics/paint/CullRect.h (left): https://codereview.chromium.org/2496983002/diff/1/third_party/WebKit/Source/platform/graphics/paint/CullRect.h#oldcode39 third_party/WebKit/Source/platform/graphics/paint/CullRect.h:39: String toString() const { return m_rect.toString(); } Why remove ...
4 years, 1 month ago (2016-11-11 19:02:17 UTC) #6
Xianzhu
https://codereview.chromium.org/2496983002/diff/1/third_party/WebKit/Source/platform/graphics/paint/CullRect.h File third_party/WebKit/Source/platform/graphics/paint/CullRect.h (left): https://codereview.chromium.org/2496983002/diff/1/third_party/WebKit/Source/platform/graphics/paint/CullRect.h#oldcode39 third_party/WebKit/Source/platform/graphics/paint/CullRect.h:39: String toString() const { return m_rect.toString(); } On 2016/11/11 ...
4 years, 1 month ago (2016-11-11 19:13:25 UTC) #7
chrishtr
lgtm
4 years, 1 month ago (2016-11-11 19:18:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496983002/40001
4 years, 1 month ago (2016-11-11 20:41:56 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 22:04:55 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 22:22:33 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/36883fc1dd5c53c5dbcb57b9209d1be001df80ee
Cr-Commit-Position: refs/heads/master@{#431661}

Powered by Google App Engine
This is Rietveld 408576698