chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h - Issue 2496973002: arc: Partially migrate mojo types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h

Issue 2496973002: arc: Partially migrate mojo types (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/arc_auth_service.cc ('k') | chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h

diff --git a/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h b/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h

index 2e38ebac50ed1dedc70ab3c230ec95a8897bcc55..9fd13987afc2f492c4984bc52511a50aae38ba09 100644

--- a/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h

+++ b/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.h

@@ -6,14 +6,14 @@

#define CHROME_BROWSER_CHROMEOS_ARC_DOWNLOADS_WATCHER_ARC_DOWNLOADS_WATCHER_SERVICE_H_

#include <memory>

+#include <string>

+#include <vector>

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "components/arc/arc_service.h"

#include "components/arc/common/file_system.mojom.h"

#include "components/arc/instance_holder.h"

-#include "mojo/public/cpp/bindings/array.h"

-#include "mojo/public/cpp/bindings/string.h"

namespace base {

class FilePath;

@@ -45,7 +45,7 @@ class ArcDownloadsWatcherService

void StartWatchingDownloads();

void StopWatchingDownloads();

- void OnDownloadsChanged(mojo::Array<mojo::String> paths);

+ void OnDownloadsChanged(std::vector<std::string> paths);

Yusuke Sato 2016/11/11 17:33:37 const std::vector<std::string>& probably? The doe

Luis Héctor Chávez 2016/11/11 17:53:38 Done.

std::unique_ptr<DownloadsWatcher> watcher_;