Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2496963004: [ash-md] Fixed the effective text/icon colors in the system menu. (Closed)

Created:
4 years, 1 month ago by bruthig
Modified:
4 years, 1 month ago
Reviewers:
tdanderson, James Cook
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, James Cook
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fixed the effective text/icon colors in the system menu. The theme providers don't appear to be providing the correct colors to the TrayPopupItemStyle class. This CL hard codes the colors as an interim fix while the underlying issue is investigated. TBR=jamescook@chromium.org BUG=664699, 664693 Committed: https://crrev.com/09353ae7e104e652e20445238faa94381fcd05df Cr-Commit-Position: refs/heads/master@{#431763}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed compile error (typo). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/tray_tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_item_more.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_popup_item_style.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ash/common/system/tray/tray_popup_item_style.cc View 3 chunks +36 lines, -11 lines 0 comments Download
M ash/common/system/tray_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
bruthig
tdanderson@, can you PTAL at ash/common/*? jamescook@, (TBR) can you PTAL at ash/system* when you ...
4 years, 1 month ago (2016-11-12 03:09:40 UTC) #5
tdanderson
LGTM https://codereview.chromium.org/2496963004/diff/1/ash/common/system/tray/tray_popup_item_style.h File ash/common/system/tray/tray_popup_item_style.h (right): https://codereview.chromium.org/2496963004/diff/1/ash/common/system/tray/tray_popup_item_style.h#newcode87 ash/common/system/tray/tray_popup_item_style.h:87: SkColor GetLTextColor() const; nit: GetTextColor (remove the L)
4 years, 1 month ago (2016-11-12 03:17:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496963004/20001
4 years, 1 month ago (2016-11-12 03:18:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 03:55:01 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/09353ae7e104e652e20445238faa94381fcd05df Cr-Commit-Position: refs/heads/master@{#431763}
4 years, 1 month ago (2016-11-12 03:57:56 UTC) #18
James Cook
4 years, 1 month ago (2016-11-14 16:57:58 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698