[ash-md] Fixed the effective text/icon colors in the system menu.

[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699, 664693
Committed: https://crrev.com/09353ae7e104e652e20445238faa94381fcd05df
Cr-Commit-Position: refs/heads/master@{#431763}

[bruthig, 2016-11-12 03:07:24]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 03:07:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-11-12 03:08:32]

Description was changed from

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

BUG=
==========

to

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=
==========

[bruthig, 2016-11-12 03:09:39]

bruthig@chromium.org changed reviewers:
+ tdanderson@chromium.org

[bruthig, 2016-11-12 03:09:40]

tdanderson@, can you PTAL at ash/common/*?

jamescook@, (TBR) can you PTAL at ash/system* when you get a chance?

[bruthig, 2016-11-12 03:10:33]

Description was changed from

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=
==========

to

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699
==========

[tdanderson, 2016-11-12 03:17:10]

LGTM

https://codereview.chromium.org/2496963004/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_popup_item_style.h (right):

https://codereview.chromium.org/2496963004/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_popup_item_style.h:87: SkColor GetLTextColor()
const;
nit: GetTextColor (remove the L)

[bruthig, 2016-11-12 03:17:50]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 03:18:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-11-12 03:18:17]

The CQ bit was unchecked by bruthig@chromium.org

[bruthig, 2016-11-12 03:18:17]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-11-12 03:18:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2496963004/#ps20001
(title: "Fixed compile error (typo).")

[commit-bot: I haz the power, 2016-11-12 03:18:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-11-12 03:21:58]

Description was changed from

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699
==========

to

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699, 664693
==========

[commit-bot: I haz the power, 2016-11-12 03:54:59]

Description was changed from

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699, 664693
==========

to

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699, 664693
==========

[commit-bot: I haz the power, 2016-11-12 03:55:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-12 03:57:54]

Description was changed from

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699, 664693
==========

to

==========
[ash-md] Fixed the effective text/icon colors in the system menu.

The theme providers don't appear to be providing the correct colors to
the TrayPopupItemStyle class. This CL hard codes the colors as an
interim fix while the underlying issue is investigated.

TBR=jamescook@chromium.org
BUG=664699, 664693

Committed: https://crrev.com/09353ae7e104e652e20445238faa94381fcd05df
Cr-Commit-Position: refs/heads/master@{#431763}
==========

[commit-bot: I haz the power, 2016-11-12 03:57:56]

Patchset 2 (id:??) landed as
https://crrev.com/09353ae7e104e652e20445238faa94381fcd05df
Cr-Commit-Position: refs/heads/master@{#431763}

[James Cook, 2016-11-14 16:57:58]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-11-14 16:57:58]

lgtm