Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2496953002: Revert of Unify enum NextProto and enum AlternateProtocol. (Closed)

Created:
4 years, 1 month ago by Bence
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unify enum NextProto and enum AlternateProtocol. (patchset #4 id:60001 of https://codereview.chromium.org/2373663002/ ) Reason for revert: https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/2943/steps/compile/logs/stdio ../../components/grpc_support/test/get_stream_engine.cc:52:56: error: no member named 'AlternateProtocol' in namespace 'net'; did you mean 'AlternateProtocolUsage'? net::AlternativeService alternative_service(net::AlternateProtocol::QUIC, ~~~~~^~~~~~~~~~~~~~~~~ AlternateProtocolUsage Original issue's description: > Unify enum NextProto and enum AlternateProtocol. > > * Use NextProto instead of AlternateProtocol everywhere. > * Remove enum AlternateProtocol, AlternateProtocolFromNextProto(). > * Move SSLClientSocketImpl::NextProto{To,From}String() to > * next_proto.cc. > * Combine AlternateProtocol{To,From}String() into > * NextProto{To,From}String(). > * Remove unused SpdyHttpStream::negotiated_protocol_. > > BUG=116575 > > Committed: https://crrev.com/f98f01d87fb1f315de400c6829ad467ae95caa7a > Cr-Commit-Position: refs/heads/master@{#431572} TBR=rch@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=116575 Committed: https://crrev.com/e1a722c1e8ee332dfa88e2b21848d333c4108c8c Cr-Commit-Position: refs/heads/master@{#431575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -262 lines) Patch
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_session.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M net/http/http_network_transaction.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 19 chunks +44 lines, -28 lines 0 comments Download
M net/http/http_server_properties.h View 3 chunks +25 lines, -8 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +52 lines, -9 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 30 chunks +48 lines, -51 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 15 chunks +23 lines, -24 lines 0 comments Download
M net/http/http_stream_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 8 chunks +13 lines, -11 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M net/log/net_log_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M net/socket/next_proto.h View 2 chunks +0 lines, -8 lines 0 comments Download
D net/socket/next_proto.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M net/socket/ssl_client_socket.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bence
Created Revert of Unify enum NextProto and enum AlternateProtocol.
4 years, 1 month ago (2016-11-11 16:37:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496953002/1
4 years, 1 month ago (2016-11-11 16:37:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 16:39:00 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 16:40:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1a722c1e8ee332dfa88e2b21848d333c4108c8c
Cr-Commit-Position: refs/heads/master@{#431575}

Powered by Google App Engine
This is Rietveld 408576698