Display linear-srgb color managed canvas

cc/resources/resource.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_RESOURCE_H_
 #define CC_RESOURCES_RESOURCE_H_
 
+#include "base/command_line.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "cc/base/cc_export.h"
+#include "cc/base/switches.h"
 #include "cc/resources/resource_provider.h"
 #include "cc/resources/resource_util.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace cc {
 
 class CC_EXPORT Resource {
  public:
-  Resource() : id_(0), format_(RGBA_8888) {}
+  Resource() : id_(0), format_(RGBA_8888) {
+    // If color correct rendering is enabled, set the default color space to
+    // SRGB instead of unspecified.
+    base::CommandLine* cmd = base::CommandLine::ForCurrentProcess();
+    if (cmd->HasSwitch(switches::kEnableColorCorrectRendering))

[Justin Novosad, 2016/11/11 19:10:30]

Calling HasSwitch is an expensive check. You should have the state of the flag
cached in a boolean. I am not sure whether there is a reasonable way to access
cc::LayerTreeSettings from here. IF so, that would be great. Worst case, you can
make a static function that returns the value of a static bool that is
initialized with the result of the HasSwitch query.  Same comment applies to all
the other calls to HasSwitch in this CL.

[zakerinasab, 2016/11/16 20:13:59]

Done.

+      color_space_ = gfx::ColorSpace::CreateSRGB();
+  }
   Resource(unsigned id,
            const gfx::Size& size,
            ResourceFormat format,
            const gfx::ColorSpace& color_space)
-      : id_(id), size_(size), format_(format), color_space_(color_space) {}
+      : id_(id), size_(size), format_(format), color_space_(color_space) {
+    if (color_space_ == gfx::ColorSpace()) {
+      // If color correct rendering is enabled, replace the unspecified color
+      // space with SRGB.
+      base::CommandLine* cmd = base::CommandLine::ForCurrentProcess();
+      if (cmd->HasSwitch(switches::kEnableColorCorrectRendering))
+        color_space_ = gfx::ColorSpace::CreateSRGB();
+    }
+  }
 
   ResourceId id() const { return id_; }
   const gfx::Size& size() const { return size_; }
   ResourceFormat format() const { return format_; }
   const gfx::ColorSpace& color_space() const { return color_space_; }
 
  protected:
   void set_id(ResourceId id) { id_ = id; }
   void set_dimensions(const gfx::Size& size, ResourceFormat format) {
     size_ = size;
     format_ = format;
   }
+
   void set_color_space(const gfx::ColorSpace& color_space) {
-    color_space_ = color_space;
+    if (color_space_ == gfx::ColorSpace()) {
+      // If color correct rendering is enabled, replace the unspecified color
+      // space with SRGB.
+      base::CommandLine* cmd = base::CommandLine::ForCurrentProcess();
+      if (cmd->HasSwitch(switches::kEnableColorCorrectRendering))
+        color_space_ = gfx::ColorSpace::CreateSRGB();
+    } else {
+      color_space_ = color_space;
+    }
   }
 
  private:
   ResourceId id_;
   gfx::Size size_;
   ResourceFormat format_;
   gfx::ColorSpace color_space_;
 
   DISALLOW_COPY_AND_ASSIGN(Resource);
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_RESOURCE_H_