src/profiler/sampling-heap-profiler.cc - Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/sampling-heap-profiler.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/sampling-heap-profiler.cc

diff --git a/src/profiler/sampling-heap-profiler.cc b/src/profiler/sampling-heap-profiler.cc

index 3b2ca630acd60bb5d59ede47a2b51da3d931def0..f2a3d4a2cb648268363593ffc1e70d993bb03c2d 100644

--- a/src/profiler/sampling-heap-profiler.cc

+++ b/src/profiler/sampling-heap-profiler.cc

@@ -65,7 +65,7 @@ SamplingHeapProfiler::SamplingHeapProfiler(

stack_depth_(stack_depth),

rate_(rate),

flags_(flags) {

- CHECK_GT(rate_, 0);

+ CHECK_GT(rate_, 0u);

heap->new_space()->AddAllocationObserver(new_space_observer_.get());

AllSpaces spaces(heap);

for (Space* space = spaces.next(); space != nullptr; space = spaces.next()) {

« no previous file with comments | « src/perf-jit.cc ('k') | test/cctest/heap/test-spaces.cc » ('j') | no next file with comments »