Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: src/perf-jit.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/profiler/sampling-heap-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/perf-jit.cc
diff --git a/src/perf-jit.cc b/src/perf-jit.cc
index a8c7255396f6529e190a2d6c407c1728ccfb9f46..23c8cc2fb4c7130397a87bb88999828f36591468 100644
--- a/src/perf-jit.cc
+++ b/src/perf-jit.cc
@@ -272,7 +272,7 @@ void PerfJitLogger::LogWriteDebugInfo(Code* code, SharedFunctionInfo* shared) {
static_cast<size_t>(name_length));
name_string = std::unique_ptr<char[]>(buffer);
}
- DCHECK_EQ(name_length, strlen(name_string.get()));
+ DCHECK_EQ(name_length, static_cast<int>(strlen(name_string.get())));
PerfJitCodeDebugInfo debug_info;
@@ -356,8 +356,8 @@ void PerfJitLogger::LogWriteUnwindingInfo(Code* code) {
}
char padding_bytes[] = "\0\0\0\0\0\0\0\0";
- DCHECK_LT(padding_size, sizeof(padding_bytes));
- LogWriteBytes(padding_bytes, padding_size);
+ DCHECK_LT(padding_size, static_cast<int>(sizeof(padding_bytes)));
+ LogWriteBytes(padding_bytes, static_cast<int>(padding_size));
}
void PerfJitLogger::CodeMoveEvent(AbstractCode* from, Address to) {
« no previous file with comments | « src/objects.cc ('k') | src/profiler/sampling-heap-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698