src/objects.cc - Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 89c40c1022b9046b3e31692270cdb01d414cd7fd..aa4186f7e7500a8bf2bda11e18134c7998facc1e 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -20310,7 +20310,7 @@ Handle<JSModuleNamespace> Module::GetModuleNamespace(Handle<Module> module) {

DCHECK(exports->ValueAt(i)->IsCell());

names.push_back(Handle<String>::cast(key));

}

- DCHECK_EQ(names.size(), exports->NumberOfElements());

+ DCHECK_EQ(static_cast<int>(names.size()), exports->NumberOfElements());

// Sort them alphabetically.

struct {

« no previous file with comments | « src/mips64/simulator-mips64.cc ('k') | src/perf-jit.cc » ('j') | no next file with comments »