Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: test/cctest/test-global-handles.cc

Issue 2496913002: Fix more -Wsign-compare warnings in heap, mips, base, etc. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-conversions.cc ('k') | test/unittests/base/atomic-utils-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 460
461 v8::Global<v8::Object> g1, g2; 461 v8::Global<v8::Object> g1, g2;
462 { 462 {
463 v8::HandleScope scope(isolate); 463 v8::HandleScope scope(isolate);
464 g1.Reset(isolate, v8::Object::New(isolate)); 464 g1.Reset(isolate, v8::Object::New(isolate));
465 g1.SetWeak(); 465 g1.SetWeak();
466 g2.Reset(isolate, v8::Object::New(isolate)); 466 g2.Reset(isolate, v8::Object::New(isolate));
467 g2.SetWeak(); 467 g2.SetWeak();
468 } 468 }
469 469
470 CHECK_EQ(0, isolate->NumberOfPhantomHandleResetsSinceLastCall()); 470 CHECK_EQ(0u, isolate->NumberOfPhantomHandleResetsSinceLastCall());
471 CcTest::CollectAllAvailableGarbage(); 471 CcTest::CollectAllAvailableGarbage();
472 CHECK_EQ(2, isolate->NumberOfPhantomHandleResetsSinceLastCall()); 472 CHECK_EQ(2u, isolate->NumberOfPhantomHandleResetsSinceLastCall());
473 CHECK_EQ(0, isolate->NumberOfPhantomHandleResetsSinceLastCall()); 473 CHECK_EQ(0u, isolate->NumberOfPhantomHandleResetsSinceLastCall());
474 } 474 }
OLDNEW
« no previous file with comments | « test/cctest/test-conversions.cc ('k') | test/unittests/base/atomic-utils-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698