Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2496833002: bluetooth: Cache device name and uuids when iterating over filters (Closed)

Created:
4 years, 1 month ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Cache device name and uuids when iterating over filters Changes MatchesFilters to take the device's name and its uuids directly rather than taking a device and getting the name and uuids when iterating over the filters. This avoid calling BluetoothDevice::GetName() for every filter which caused lag on android when the request had too many filters. BUG=629456 Committed: https://crrev.com/f6c78e7050d893ffb0ccb150efa8d21703593a95 Cr-Commit-Position: refs/heads/master@{#432026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 4 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ortuno
scheib: PTAL. This occurred to me when working on something completely different :)
4 years, 1 month ago (2016-11-11 03:17:21 UTC) #4
scheib
LGTM
4 years, 1 month ago (2016-11-14 21:59:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496833002/1
4 years, 1 month ago (2016-11-14 22:59:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 00:44:30 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:50:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6c78e7050d893ffb0ccb150efa8d21703593a95
Cr-Commit-Position: refs/heads/master@{#432026}

Powered by Google App Engine
This is Rietveld 408576698