Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 249683002: Rename WiFiService::GetConnectedProperties into GetCurrentProperties. (Closed)

Created:
6 years, 8 months ago by mef
Modified:
6 years, 8 months ago
Reviewers:
afontan, tbarzic
CC:
chromium-reviews
Visibility:
Public.

Description

Rename WiFiService::GetConnectedProperties into GetCurrentProperties to reflect the fact that current network associated with wlan interface may be not connected but transitioning on Windows. BUG=364907 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265794

Patch Set 1 #

Total comments: 2

Patch Set 2 : git cl format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M components/wifi/wifi_service_win.cc View 1 9 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
mef
Hi guys, take a look. I've addressed Antonio's comments to https://codereview.chromium.org/245313002.
6 years, 8 months ago (2014-04-23 16:34:25 UTC) #1
afontan
lgtm
6 years, 8 months ago (2014-04-23 16:44:21 UTC) #2
mef
On 2014/04/23 16:44:21, afontan wrote: > lgtm thanks!
6 years, 8 months ago (2014-04-23 16:46:21 UTC) #3
tbarzic
lgtm https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service_win.cc File components/wifi/wifi_service_win.cc (right): https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service_win.cc#newcode675 components/wifi/wifi_service_win.cc:675: onc::connection_state::kConnected && nit: increasing indent (+4) here would ...
6 years, 8 months ago (2014-04-23 16:50:20 UTC) #4
mef
Thanks! https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service_win.cc File components/wifi/wifi_service_win.cc (right): https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service_win.cc#newcode675 components/wifi/wifi_service_win.cc:675: onc::connection_state::kConnected && On 2014/04/23 16:50:20, tbarzic wrote: > ...
6 years, 8 months ago (2014-04-23 17:04:21 UTC) #5
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-23 17:04:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
6 years, 8 months ago (2014-04-23 17:05:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 17:09:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-23 17:09:47 UTC) #9
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-23 17:10:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
6 years, 8 months ago (2014-04-23 17:10:44 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 17:13:05 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-23 17:13:06 UTC) #13
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-23 17:26:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
6 years, 8 months ago (2014-04-23 17:27:02 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 17:37:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-23 17:37:56 UTC) #17
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-23 20:37:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
6 years, 8 months ago (2014-04-23 20:38:02 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 00:37:31 UTC) #20
Message was sent while issue was closed.
Change committed as 265794

Powered by Google App Engine
This is Rietveld 408576698