|
|
Created:
6 years, 8 months ago by mef Modified:
6 years, 8 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionRename WiFiService::GetConnectedProperties into GetCurrentProperties to reflect the fact that current network associated with wlan interface may be not connected but transitioning on Windows.
BUG=364907
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265794
Patch Set 1 #
Total comments: 2
Patch Set 2 : git cl format. #Messages
Total messages: 20 (0 generated)
Hi guys, take a look. I've addressed Antonio's comments to https://codereview.chromium.org/245313002.
lgtm
On 2014/04/23 16:44:21, afontan wrote: > lgtm thanks!
lgtm https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service... File components/wifi/wifi_service_win.cc (right): https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service... components/wifi/wifi_service_win.cc:675: onc::connection_state::kConnected && nit: increasing indent (+4) here would make it easier to read. (I'd suggest running 'git cl format' it should take care of nits like this)
Thanks! https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service... File components/wifi/wifi_service_win.cc (right): https://codereview.chromium.org/249683002/diff/1/components/wifi/wifi_service... components/wifi/wifi_service_win.cc:675: onc::connection_state::kConnected && On 2014/04/23 16:50:20, tbarzic wrote: > nit: increasing indent (+4) here would make it easier to read. > > (I'd suggest running 'git cl format' it should take care of nits like this) Done.
The CQ bit was checked by mef@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_rel
The CQ bit was checked by mef@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by mef@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by mef@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/249683002/10001
Message was sent while issue was closed.
Change committed as 265794 |