content/test/gpu/gpu_tests/webgl2_conformance_expectations.py - Issue 2496813002: [Command buffer] workaround the framebuffer completeness bug for Intel Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Issue 2496813002: [Command buffer] workaround the framebuffer completeness bug for Intel Mac (Closed)

Patch Set: code refactoring per zmo@'s suggestion: move read/draw buffer adjustment into CheckBound{Read|Draw}FramebufferValid Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

diff --git a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

index f3c9b93cc1d66354bf34cf19e611e84bfc3b6aef..8ae5920dc871852b1cbdcc1508499e2d81c66dae 100644

--- a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

+++ b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

@@ -133,15 +133,12 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):

self.Fail('conformance2/rendering/' +

'framebuffer-completeness-unaffected.html',

['mac'], bug=630800)

Zhenyao Mo 2016/11/16 03:27:27 What about this one? They are the same root cause

- self.Fail('deqp/functional/gles3/fbocompleteness.html',

- ['mac'], bug=630800)

- # self.Fail('deqp/functional/gles3/fbocompleteness.html',

- # ['mac', ('nvidia', 0xfe9)], bug=616562)

self.Fail('conformance2/renderbuffers/framebuffer-test.html',

['mac'], bug=641149)

# Mac Retina NVIDIA

+ self.Fail('deqp/functional/gles3/fbocompleteness.html',

+ ['mac', ('nvidia', 0xfe9)], bug=616562)

self.Fail('deqp/functional/gles3/fbomultisample*',

['mac', ('nvidia', 0xfe9)], bug=641209)

self.Fail('deqp/functional/gles3/framebufferblit/' +

@@ -291,7 +288,6 @@ class WebGL2ConformanceExpectations(WebGLConformanceExpectations):

['mac', 'amd'], bug=643866)

self.Fail('deqp/functional/gles3/shadercommonfunction.html',

['mac', 'amd'], bug=643866)

self.Fail('deqp/functional/gles3/multisample.html',

['mac', 'amd'], bug=617290)

self.Fail('deqp/functional/gles3/primitiverestart/00.html',

« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | gpu/command_buffer/service/framebuffer_manager.cc » ('J')