[Command buffer] workaround the framebuffer completeness bug for Intel Mac

gpu/command_buffer/service/framebuffer_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/framebuffer_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/logging.h"
@@ skipping 593 matching lines @@
 }
 
 bool Framebuffer::HasDepthAttachment() const {
   return attachments_.find(GL_DEPTH_ATTACHMENT) != attachments_.end();
 }
 
 bool Framebuffer::HasStencilAttachment() const {
   return attachments_.find(GL_STENCIL_ATTACHMENT) != attachments_.end();
 }
 
+bool Framebuffer::ReadBufferHasNoImage() const {
+  if (read_buffer_ == GL_NONE) {
+    return false;
+  }
+  AttachmentMap::const_iterator it = attachments_.find(read_buffer_);
+  if (it == attachments_.end()) {

[Zhenyao Mo, 2016/11/14 19:42:24]

Just return it == attachments_.end().

[yunchao, 2016/11/15 16:21:58]

Done.

+    return true;
+  }
+  return false;
+}
+
+bool Framebuffer::DrawBuffersHaveNoImage(GLsizei& num, GLenum* buf) const {
+  bool ret = false;
+  for (GLenum i = 0; i < manager_->max_draw_buffers_; ++i) {
+    if (draw_buffers_[i] == GL_NONE) {
+      buf[i] = GL_NONE;
+      continue;
+    }
+    const Attachment* attachment = GetAttachment(draw_buffers_[i]);
+    if (attachment) {
+      buf[i] = GL_COLOR_ATTACHMENT0 + i;

[Zhenyao Mo, 2016/11/14 19:42:24]

Here you should DCHECK(buf[i] == GL_COLOR_ATTACHMENT0 + i). No need to re-assign
the value.

[yunchao, 2016/11/15 16:21:58]

Not re-assign. The buf[] passed in are all GL_NONE.

+      ++num;

[Zhenyao Mo, 2016/11/14 19:42:24]

Here you assume num is initialized to zero by caller, which is bug prone.

ANyway, I don't think you need to care about num at all. Just get rid of it.

[yunchao, 2016/11/15 16:21:58]

See the explanation elsewhere.

+    } else {
+      buf[i] = GL_NONE;
+      ret = true;
+    }
+  }
+  return ret;
+}
+
+bool Framebuffer::ColorBuffersHaveImage() const {
+  for (GLenum i = 0; i < manager_->max_color_attachments_; i++) {
+    if (attachments_.find(GL_COLOR_ATTACHMENT0 + i) != attachments_.end())
+      return true;
+  }
+  return false;
+}
+
 GLenum Framebuffer::GetReadBufferInternalFormat() const {
   if (read_buffer_ == GL_NONE)
     return 0;
   AttachmentMap::const_iterator it = attachments_.find(read_buffer_);
   if (it == attachments_.end()) {
     return 0;
   }
   const Attachment* attachment = it->second.get();
   if (attachment->EmulatingRGB()) {
     DCHECK_EQ(static_cast<GLenum>(GL_RGBA), attachment->internal_format());
@@ skipping 432 matching lines @@
 
 bool FramebufferManager::IsComplete(
     Framebuffer* framebuffer) {
   DCHECK(framebuffer);
   return framebuffer->framebuffer_complete_state_count_id() ==
       framebuffer_state_change_count_;
 }
 
 }  // namespace gles2
 }  // namespace gpu