gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h - Issue 2496783002: gpu: Reuse existing code for shared memory allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h

Issue 2496783002: gpu: Reuse existing code for shared memory allocation. (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h

diff --git a/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h b/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h

index 0ad9e3fa80c1b99793f8a4b672638d192c5e27f2..b991f9572fabb73ae04ac35b3472e242a19b5c85 100644

--- a/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h

+++ b/gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h

@@ -29,8 +29,7 @@ class GPU_EXPORT GpuMemoryBufferImplSharedMemory : public GpuMemoryBufferImpl {

static gfx::GpuMemoryBufferHandle AllocateForChildProcess(

gfx::GpuMemoryBufferId id,

const gfx::Size& size,

- gfx::BufferFormat format,

- base::ProcessHandle child_process);

+ gfx::BufferFormat format);

static std::unique_ptr<GpuMemoryBufferImplSharedMemory> CreateFromHandle(

const gfx::GpuMemoryBufferHandle& handle,