Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: base/memory/shared_memory_mac.cc

Issue 2496783002: gpu: Reuse existing code for shared memory allocation. (Closed)
Patch Set: nacl Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/shared_memory.h ('k') | base/memory/shared_memory_nacl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_mac.cc
diff --git a/base/memory/shared_memory_mac.cc b/base/memory/shared_memory_mac.cc
index 0b3a62f0e7a44643c786fe239ec5862377e657e6..5cc3c68461cac8bcef475364653877d6429e6fd0 100644
--- a/base/memory/shared_memory_mac.cc
+++ b/base/memory/shared_memory_mac.cc
@@ -177,6 +177,11 @@ SharedMemoryHandle SharedMemory::handle() const {
return shm_;
}
+SharedMemoryHandle SharedMemory::TakeHandle() {
+ NOTREACHED();
sadrul 2016/11/11 02:00:30 Can I do return std::move(shm_);?
Nico 2016/11/14 18:53:51 erikchen wrote this. Erik, can you answer?
erikchen 2016/11/14 19:37:53 SharedMemoryHandle doesn't have ownership semantic
+ return SharedMemoryHandle();
+}
+
void SharedMemory::Close() {
shm_.Close();
shm_ = SharedMemoryHandle();
« no previous file with comments | « base/memory/shared_memory.h ('k') | base/memory/shared_memory_nacl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698