Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2496773002: Mojo C++ bindings: switch ui/platform_window mojom target to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch ui/platform_window mojom target to use STL types. BUG=624136 TBR=sky@chromium.org Committed: https://crrev.com/bee9d25dd206a08d4b9b1bd86900cc354d8bb4e0 Cr-Commit-Position: refs/heads/master@{#431463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M ui/platform_window/mojo/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
A ui/platform_window/mojo/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/platform_window/mojo/ime_type_converters.cc View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yzshen1
Hi, Daniel. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-10 23:35:56 UTC) #4
dcheng
LGTM
4 years, 1 month ago (2016-11-11 00:08:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496773002/1
4 years, 1 month ago (2016-11-11 00:50:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 02:11:12 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 02:14:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bee9d25dd206a08d4b9b1bd86900cc354d8bb4e0
Cr-Commit-Position: refs/heads/master@{#431463}

Powered by Google App Engine
This is Rietveld 408576698