Disable content intent detectors in the renderer

Disable content intent detectors in the renderer

BUG=664307, 657063
Committed: https://crrev.com/2449b35f7561d4374347605b0b234d781f971297
Cr-Commit-Position: refs/heads/master@{#431448}

[Theresa, 2016-11-10 23:12:54]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 23:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-11-10 23:15:25]

twellington@chromium.org changed reviewers:
+ aelias@chromium.org, boliu@chromium.org

[Theresa, 2016-11-10 23:15:25]

ptal

[boliu, 2016-11-10 23:21:55]

https://codereview.chromium.org/2496763002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java
(right):

https://codereview.chromium.org/2496763002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java:18:
@CommandLineFlags.Add({ContentSwitches.ENABLE_CONTENT_INTENT_DETECTION})
hmm, does this override the CommandLineFlags.Add on the individual tests, or as
the name implies, *add* to the list?

[aelias_OOO_until_Jul13, 2016-11-10 23:27:37]

lgtm

https://codereview.chromium.org/2496763002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2496763002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:2696: return  WebURL();;
nit: duplicate whitespace and semicolons

[Theresa, 2016-11-10 23:31:46]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2016-11-10 23:32:19]

https://codereview.chromium.org/2496763002/diff/1/content/public/android/java...
File
content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java
(right):

https://codereview.chromium.org/2496763002/diff/1/content/public/android/java...
content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java:18:
@CommandLineFlags.Add({ContentSwitches.ENABLE_CONTENT_INTENT_DETECTION})
On 2016/11/10 23:21:55, boliu wrote:
> hmm, does this override the CommandLineFlags.Add on the individual tests, or
as
> the name implies, *add* to the list?

It adds them to the list.

https://codereview.chromium.org/2496763002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2496763002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:2696: return  WebURL();;
On 2016/11/10 23:27:37, aelias wrote:
> nit: duplicate whitespace and semicolons

Done.

[commit-bot: I haz the power, 2016-11-10 23:32:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-11-10 23:41:33]

twellington@chromium.org changed reviewers:
+ nasko@chromium.org

[Theresa, 2016-11-10 23:41:34]

+nasko@ - ptal at content/public/common/content_switches.cc

[boliu, 2016-11-10 23:46:58]

lgtm

[commit-bot: I haz the power, 2016-11-10 23:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:49:27]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Theresa, 2016-11-11 00:13:36]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[nasko, 2016-11-11 00:14:07]

Switches LGTM.

[commit-bot: I haz the power, 2016-11-11 00:14:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-11-11 01:08:13]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2016-11-11 01:08:13]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-11-11 01:08:14]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2496763002/#ps20001
(title: "Disable content intent detectors in the renderer")

[commit-bot: I haz the power, 2016-11-11 01:08:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:45:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-11 01:54:55]

Description was changed from

==========
Disable content intent detectors in the renderer

BUG=664307,657063
==========

to

==========
Disable content intent detectors in the renderer

BUG=664307,657063

Committed: https://crrev.com/2449b35f7561d4374347605b0b234d781f971297
Cr-Commit-Position: refs/heads/master@{#431448}
==========

[commit-bot: I haz the power, 2016-11-11 01:54:56]

Patchset 2 (id:??) landed as
https://crrev.com/2449b35f7561d4374347605b0b234d781f971297
Cr-Commit-Position: refs/heads/master@{#431448}