Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2496733002: Mojo C++ bindings: switch ios/web mojom targets to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, mac-reviews_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch ios/web mojom targets to use STL types. BUG=624136 Committed: https://crrev.com/b6f82a3d71281afc6224a6fde0a733be9c7bc4c3 Cr-Commit-Position: refs/heads/master@{#431407}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M ios/web/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yzshen1
Hi, Eugene. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-10 22:25:35 UTC) #4
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-11-10 22:30:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496733002/1
4 years, 1 month ago (2016-11-10 22:32:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:28:08 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:31:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6f82a3d71281afc6224a6fde0a733be9c7bc4c3
Cr-Commit-Position: refs/heads/master@{#431407}

Powered by Google App Engine
This is Rietveld 408576698