Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 2496723002: [MSAN] Initialize video_ and audio_track_id_ in media_unittest. (Closed)

Created:
4 years, 1 month ago by mbjorge
Modified:
4 years, 1 month ago
Reviewers:
halliwell, servolk, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MSAN] Initialize video_ and audio_track_id_ in media_unittest. BUG=664542 Committed: https://crrev.com/546ead35f537cc045d91ec48569876c52ee4d175 Cr-Commit-Position: refs/heads/master@{#431601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/formats/mp2t/mp2t_stream_parser_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
mbjorge
4 years, 1 month ago (2016-11-10 22:03:12 UTC) #2
mbjorge
4 years, 1 month ago (2016-11-11 00:34:31 UTC) #4
wolenetz
LGTM -- I spotted this as well when running various tests as part of the ...
4 years, 1 month ago (2016-11-11 00:38:55 UTC) #5
wolenetz
nit: please update CL description with a BUG= (file one if needed)
4 years, 1 month ago (2016-11-11 00:39:42 UTC) #6
mbjorge
On 2016/11/11 at 00:39:42, wolenetz wrote: > nit: please update CL description with a BUG= ...
4 years, 1 month ago (2016-11-11 17:03:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496723002/1
4 years, 1 month ago (2016-11-11 17:04:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 18:28:19 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 19:00:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/546ead35f537cc045d91ec48569876c52ee4d175
Cr-Commit-Position: refs/heads/master@{#431601}

Powered by Google App Engine
This is Rietveld 408576698