Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2496713003: Mojo C++ bindings: switch mash/init mojom target to use STL types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch mash/init mojom target to use STL types. BUG=624136 Committed: https://crrev.com/119cca624a18ec79c478f2df10f57940a8bb19d9 Cr-Commit-Position: refs/heads/master@{#431428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M mash/init/init.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mash/init/init.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mash/init/public/interfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
yzshen1
Hi, Mike. Would you please take a look at this CL? Thanks!
4 years, 1 month ago (2016-11-10 22:37:37 UTC) #2
msw
lgtm!
4 years, 1 month ago (2016-11-10 22:47:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2496713003/1
4 years, 1 month ago (2016-11-10 22:50:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:48:59 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:52:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/119cca624a18ec79c478f2df10f57940a8bb19d9
Cr-Commit-Position: refs/heads/master@{#431428}

Powered by Google App Engine
This is Rietveld 408576698