content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java - Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java ('K') | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | ui/android/java/res/layout/dropdown_item.xml » ('j') | ui/android/java/res/layout/dropdown_item.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

index 93ff24fca68c39dc94f86b4e3f572f1194b21336..88058fb0b4fd06e52eb1fb043276b65547dc750a 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

@@ -49,6 +49,16 @@ public class SelectPopupItem implements DropdownItem {

return false;

}

+ @Override

+ public boolean getLabelFontColor() {

+ return R.drawable.dropdown_label_color;

+ }

+ @Override

+ public boolean getLabelFontSize() {

+ return R.dimen.dropdown_item_label_size;

+ }

public int getType() {

return mType;

}