Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: ui/android/java/src/org/chromium/ui/DropdownAdapter.java

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: minor change Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/src/org/chromium/ui/DropdownAdapter.java
diff --git a/ui/android/java/src/org/chromium/ui/DropdownAdapter.java b/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
index ecad3cea4f588945da019472d7768c4ad1df0f31..d54aef0f5ebad8a493349c3698456a005083704e 100644
--- a/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
+++ b/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
@@ -99,6 +99,12 @@ public class DropdownAdapter extends ArrayAdapter<DropdownItem> {
labelView.setTypeface(null, Typeface.NORMAL);
}
+ if (item.isHttpWarningMessage()) {
+ labelView.setTextColor(ApiCompatibilityUtils.getColor(
+ mContext.getResources(), R.color.http_bad_warning_message_text));
+ labelView.setTextSize(14);
csashi 2016/11/12 22:45:55 Should the text size be in resources too?
lshang 2016/11/14 10:51:01 Done.
+ }
+
TextView sublabelView = (TextView) layout.findViewById(R.id.dropdown_sublabel);
CharSequence sublabel = item.getSublabel();
if (TextUtils.isEmpty(sublabel)) {

Powered by Google App Engine
This is Rietveld 408576698