Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: minor change Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/autofill/core/browser/autofill_manager.cc ('K') | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/popup_item_ids.h » ('j') | ui/android/java/res/values/colors.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager_unittest.cc
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc
index 034bd5bd7afc88693be923bc3f0bb6a168669471..c2b10d199e197c534b9894872784f487aba4904e 100644
--- a/components/autofill/core/browser/autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc
@@ -1629,7 +1629,7 @@ TEST_F(AutofillManagerTest,
kDefaultPageID,
Suggestion(l10n_util::GetStringUTF8(
IDS_AUTOFILL_CREDIT_CARD_HTTP_WARNING_MESSAGE),
- "", "", -1),
+ "", "", -10),
Mathieu 2016/11/12 12:52:05 let's use proper popup_item_ids values.
lshang 2016/11/14 10:51:01 Done.
Suggestion(
l10n_util::GetStringUTF8(IDS_AUTOFILL_WARNING_INSECURE_CONNECTION),
"", "", -1));
« components/autofill/core/browser/autofill_manager.cc ('K') | « components/autofill/core/browser/autofill_manager.cc ('k') | components/autofill/core/browser/popup_item_ids.h » ('j') | ui/android/java/res/values/colors.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698