Http Bad: Add a PopupItemId to identify http warning message

components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java

Index: components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java
diff --git a/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java b/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java
index cfe248c61ac5de25b3877cc29d0a1842fc9a85ae..be0a49429cb2b8dac22cc9f952a1adf751d9dbde 100644
--- a/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java
+++ b/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java
@@ -16,6 +16,7 @@ public class AutofillSuggestion implements DropdownItem {
     private final int mSuggestionId;
     private final boolean mDeletable;
     private final boolean mIsMultilineLabel;
+    private final boolean mIsHttpWarningMessage;
 
     /**
      * Constructs a Autofill suggestion container.
@@ -24,15 +25,17 @@ public class AutofillSuggestion implements DropdownItem {
      * @param suggestionId The type of suggestion.
      * @param deletable Whether the item can be deleted by the user.
      * @param multilineLabel Whether the label is displayed over multiple lines.
+     * @param isHttpWarningMessage Whether the item is a Http bad warning message.
      */
     public AutofillSuggestion(String label, String sublabel, int iconId, int suggestionId,
-            boolean deletable, boolean multilineLabel) {
+            boolean deletable, boolean multilineLabel, boolean isHttpWarningMessage) {
         mLabel = label;
         mSublabel = sublabel;
         mIconId = iconId;
         mSuggestionId = suggestionId;
         mDeletable = deletable;
         mIsMultilineLabel = multilineLabel;
+        mIsHttpWarningMessage = isHttpWarningMessage;
     }
 
     @Override
@@ -65,6 +68,11 @@ public class AutofillSuggestion implements DropdownItem {
         return mIsMultilineLabel;
     }
 
+    @Override
+    public boolean isHttpWarningMessage() {

[Mathieu, 2016/11/12 12:52:05]

Too specific. Let me try to make a suggestion... Instead of this, could it be
better to have @Override methods from DropdownItem that are more generic?

(FYI Label means the "value" in this file and Sublabel means "label") 

@Override
public int getLabelFontColor() {  
   // look at mSuggestionId to make a decision
}

@Override
public isBiggerSublabelFontSize() {
  // same
}

That way you can use those methods in DropdownAdapter without referencing
Autofill functionality.

+csashi to get his opinion because he is looking at this code as well

[csashi, 2016/11/12 22:45:55]

For context, I am working on experimenting with credit card auto fill popups
(crbug.com/664367). For this experiment, I was planning to add interfaces such
that Dropdown Adapter is not cognizant of whether we are in a credit card form
(along the same lines as Mathieu's suggestion). I was planning on making
AutofillPopupLayoutModel aware of whether the popup layout is for a credit card.

[lshang, 2016/11/14 10:51:01]

I try to add interfaces to get font color and font size from here, and use id
references defined in colors.xml and dimens.xml, but compiler complains about
symbol not found because those resources are in ui/android/java/res/. I'm not
sure how to get resources form another root directory. Any idea of fixing this?

I would also suggest use a simple e.g. getDropdownType() in DropdownItem and
adjust UI in DropdownAdapter according to different types. I think that might
makes code simpler because according to the autofill http warning message mocks
(https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Form%20Not%...)
we might have several places to adjust, like paddings, position of icons, which
need to add several more interfaces here. But I don't have enough backgrounds of
dropdowns so I'm happy to do the way as you and csashi@ strongly prefer :-)

[Mathieu, 2016/11/14 14:40:15]

In order to access dimens and color from components/autofill, perhaps you can
copy what was done using this file, in keyboard accessory view?
https://cs.chromium.org/chromium/src/components/autofill/android/java/res/val...

Regarding using resources from ui/android/...xml in components/autofill, I'm not
sure. 

[Mathieu, 2016/11/14 14:41:58]

The other suggestions I made regarding calling the super class, if they work and
are acceptable, would avoid you needing to access resources from ui/android in
this file.

+        return mIsHttpWarningMessage;
+    }
+
     public int getSuggestionId() {
         return mSuggestionId;
     }