Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: minor change Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
index 8266579e627fd955cb7a3fc6b8a88efb263ba1e4..792fc4877cbeec2132187e9a5ba877287cc740fa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java
@@ -125,14 +125,15 @@ public class AutofillPopupBridge implements AutofillDelegate, DialogInterface.On
* @param suggestionId Identifier for the suggestion type.
* @param deletable Whether this item is deletable.
* @param isLabelMultiline Whether the label should be should over multiple lines.
+ * @param isHttpWarningMeddage Whether the item is a HTTP bad warning message.
csashi 2016/11/12 22:45:55 s/Meddage/Message
lshang 2016/11/14 10:51:01 Done.
*/
@CalledByNative
private static void addToAutofillSuggestionArray(AutofillSuggestion[] array, int index,
String label, String sublabel, int iconId, int suggestionId, boolean deletable,
- boolean isLabelMultiline) {
+ boolean isLabelMultiline, boolean isHttpWarningMessage) {
int drawableId = iconId == 0 ? DropdownItem.NO_ICON : ResourceId.mapToDrawableId(iconId);
- array[index] = new AutofillSuggestion(
- label, sublabel, drawableId, suggestionId, deletable, isLabelMultiline);
+ array[index] = new AutofillSuggestion(label, sublabel, drawableId, suggestionId, deletable,
+ isLabelMultiline, isHttpWarningMessage);
}
private native void nativeSuggestionSelected(long nativeAutofillPopupViewAndroid,

Powered by Google App Engine
This is Rietveld 408576698