Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | ui/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
index 93ff24fca68c39dc94f86b4e3f572f1194b21336..36c4925b1a1806d584e862c61fdacff088e938cf 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java
@@ -4,13 +4,13 @@
package org.chromium.content.browser.input;
-import org.chromium.ui.DropdownItem;
+import org.chromium.ui.DropdownItemBase;
/**
* Select popup item containing the label, the type and the enabled state
* of an item belonging to a select popup dialog.
*/
-public class SelectPopupItem implements DropdownItem {
+public class SelectPopupItem extends DropdownItemBase {
private final String mLabel;
private final int mType;
@@ -25,16 +25,6 @@ public class SelectPopupItem implements DropdownItem {
}
@Override
- public String getSublabel() {
- return null;
- }
-
- @Override
- public int getIconId() {
- return NO_ICON;
- }
-
- @Override
public boolean isEnabled() {
return mType == PopupItemType.ENABLED || mType == PopupItemType.GROUP;
}
@@ -44,11 +34,6 @@ public class SelectPopupItem implements DropdownItem {
return mType == PopupItemType.GROUP;
}
- @Override
- public boolean isMultilineLabel() {
- return false;
- }
-
public int getType() {
return mType;
}
« no previous file with comments | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | ui/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698