chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm - Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)

Patch Set: update Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

index 35856a79bef1a7eddf524a1ff51f83368fbe40c7..a4fb09058b8dbbae42a9f9435742c0223f2be91f 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

@@ -195,6 +195,9 @@ using autofill::AutofillPopupLayoutModel;

rightAlign:(BOOL)rightAlign

bounds:(NSRect)bounds

textYOffset:(CGFloat)textYOffset {

+ // TODO(crbug.com/666189): Use

+ // AutofillPopupLayoutModel::GetValueFontColorForRow() instead and remove

+ // IsWarning() method.

NSColor* nameColor =

controller_->IsWarning(index) ? [self warningColor] : [self nameColor];

NSDictionary* nameAttributes = [NSDictionary