Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)
Patch Set: update Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/autofill/popup_constants.h ('K') | « chrome/browser/ui/autofill/popup_constants.h ('k') | chrome/browser/ui/views/autofill/autofill_popup_view_views.cc » ('j') | chrome/browser/ui/views/autofill/autofill_popup_view_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
index 35856a79bef1a7eddf524a1ff51f83368fbe40c7..8151c3c67dfd2b76cecf80e7641600cdb2f3b039 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
@@ -196,6 +196,9 @@ using autofill::AutofillPopupLayoutModel;
bounds:(NSRect)bounds
textYOffset:(CGFloat)textYOffset {
NSColor* nameColor =
+ // TODO(crbug.com/666189): Use
msw 2016/11/17 18:49:39 Put this comment above the entire statement.
lshang 2016/11/18 00:03:19 Done.
+ // AutofillPopupLayoutModel::GetValueFontColorForRow() instead and remove
+ // IsWarning() method.
controller_->IsWarning(index) ? [self warningColor] : [self nameColor];
NSDictionary* nameAttributes = [NSDictionary
dictionaryWithObjectsAndKeys:controller_->layout_model()
« chrome/browser/ui/autofill/popup_constants.h ('K') | « chrome/browser/ui/autofill/popup_constants.h ('k') | chrome/browser/ui/views/autofill/autofill_popup_view_views.cc » ('j') | chrome/browser/ui/views/autofill/autofill_popup_view_views.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698