components/password_manager/core/browser/password_autofill_manager.cc - Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)

Patch Set: back iswarning Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/android/java/res/values/dimens.xml ('K') | « components/autofill/core/browser/popup_item_ids.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java » ('j') | ui/android/java/src/org/chromium/ui/DropdownItemImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc

index b52e4f127b54cf7c126178e9f16f25020c251466..7257057a95ecc572a1462bdc9ca4b5014b5c14de 100644

--- a/components/password_manager/core/browser/password_autofill_manager.cc

+++ b/components/password_manager/core/browser/password_autofill_manager.cc

@@ -222,7 +222,7 @@ void PasswordAutofillManager::OnShowPasswordSuggestions(

l10n_util::GetStringUTF16(

IDS_AUTOFILL_PASSWORD_HTTP_WARNING_MESSAGE));

password_field_http_warning_suggestion.frontend_id =

- autofill::POPUP_ITEM_ID_WARNING_MESSAGE;

+ autofill::POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;

suggestions.insert(suggestions.begin(),

password_field_http_warning_suggestion);

}