ui/android/java/res/values/dimens.xml - Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/values/dimens.xml

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <resources>	7 <resources>

8 <dimen name="dropdown_item_height">50dp</dimen>	8 <dimen name="dropdown_item_height">50dp</dimen>

9 <dimen name="dropdown_item_divider_height">1px</dimen>	9 <dimen name="dropdown_item_divider_height">1px</dimen>

	10 <dimen name="dropdown_item_label_size">18sp</dimen>
	Mathieu 2016/11/14 14:40:15 dropdown_item_label_font_size? same below dropdown_item_label_font_size? same below lshang 2016/11/15 04:36:41 Done. Show quoted text On 2016/11/14 14:40:15, Mathieu Perreault wrote: > dropdown_item_label_font_size? > > same below Done.
	11 <dimen name="dropdown_item_smaller_label_size">14sp</dimen>

10	12

11 <!--	13 <!--

12 Fallback values if the corresponding com.android.internal.R dimensions	14 Fallback values if the corresponding com.android.internal.R dimensions

13 cannot be retrieved by name.	15 cannot be retrieved by name.

14 Note: Constants taken directly from Android's core/res/values/config.xm l.	16 Note: Constants taken directly from Android's core/res/values/config.xm l.

15 -->	17 -->

16 <dimen name="config_min_scaling_span">12.0mm</dimen>	18 <dimen name="config_min_scaling_span">12.0mm</dimen>

17 </resources>	19 </resources>

OLD	NEW

« ui/android/java/res/values/colors.xml ('K') | « ui/android/java/res/values/colors.xml ('k') | ui/android/java/src/org/chromium/ui/DropdownAdapter.java » ('j') | no next file with comments »