ui/android/java/res/values/colors.xml - Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/values/colors.xml

Issue 2496683003: Http Bad: Add a PopupItemId to identify http warning message (Closed)

Patch Set: address review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <resources>	7 <resources>

8 <color name="dropdown_divider_color">#E5E5E5</color>	8 <color name="dropdown_divider_color">#E5E5E5</color>

9 <color name="dropdown_dark_divider_color">#C0C0C0</color>	9 <color name="dropdown_dark_divider_color">#C0C0C0</color>

	10

	11 <!-- Http Bad warning message colors -->

	12 <color name="http_bad_warning_message_text">#C93929</color>
	Mathieu 2016/11/14 14:40:15 ideally this wouldn't be in this file because it's ideally this wouldn't be in this file because it's too specific for ui/android/... lshang 2016/11/15 04:36:41 Done. Moved it to components/autofill/ Show quoted text On 2016/11/14 14:40:15, Mathieu Perreault wrote: > ideally this wouldn't be in this file because it's too specific for > ui/android/... Done. Moved it to components/autofill/
10 </resources>	13 </resources>

11	14

OLD	NEW