Http Bad: Add a PopupItemId to identify http warning message

components/autofill/core/browser/autofill_external_delegate.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 13 matching lines @@
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/common/autofill_util.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace autofill {
 
 namespace {
 
 // Returns true if the suggestion entry is an Autofill warning message.
 // Warning message should display on top of suggestion list.

[Mathieu, 2016/11/12 12:52:05]

nit: Warning messages*

[lshang, 2016/11/14 10:51:01]

Done.

 bool IsAutofillWarningEntry(int frontend_id) {
-  return frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE;
+  return frontend_id == POPUP_ITEM_ID_WARNING_MESSAGE ||
+         frontend_id == POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE;
 }
 
 } // anonymous namespace
 
 AutofillExternalDelegate::AutofillExternalDelegate(AutofillManager* manager,
                                                    AutofillDriver* driver)
     : manager_(manager),
       driver_(driver),
       query_id_(0),
       has_autofill_suggestions_(false),
@@ skipping 239 matching lines @@
 }
 
 void AutofillExternalDelegate::OnCreditCardScanned(const CreditCard& card) {
   manager_->FillCreditCardForm(query_id_, query_form_, query_field_, card,
                                base::string16());
 }
 
 void AutofillExternalDelegate::FillAutofillFormData(int unique_id,
                                                     bool is_preview) {
   // If the selected element is a warning we don't want to do anything.
-  if (unique_id == POPUP_ITEM_ID_WARNING_MESSAGE)
+  if (unique_id == POPUP_ITEM_ID_WARNING_MESSAGE ||

[Mathieu, 2016/11/12 12:52:05]

reuse IsAutofillWarningEntry()?

[lshang, 2016/11/14 10:51:01]

Done.

+      unique_id == POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE)
     return;
 
   AutofillDriver::RendererFormDataAction renderer_action = is_preview ?
       AutofillDriver::FORM_DATA_ACTION_PREVIEW :
       AutofillDriver::FORM_DATA_ACTION_FILL;
 
   DCHECK(driver_->RendererIsAvailable());
   // Fill the values for the whole form.
   manager_->FillOrPreviewForm(renderer_action,
                               query_id_,
@@ skipping 71 matching lines @@
   suggestions->insert(suggestions->begin(), data_list_values_.size(),
                       Suggestion());
   for (size_t i = 0; i < data_list_values_.size(); i++) {
     (*suggestions)[i].value = data_list_values_[i];
     (*suggestions)[i].label = data_list_labels_[i];
     (*suggestions)[i].frontend_id = POPUP_ITEM_ID_DATALIST_ENTRY;
   }
 }
 
 }  // namespace autofill