content/renderer/screen_orientation/screen_orientation_dispatcher.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_dispatcher.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/renderer_blink_platform_impl.h ('k') | content/renderer/service_worker/embedded_worker_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.h

diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.h b/content/renderer/screen_orientation/screen_orientation_dispatcher.h

index 21d31f5feea76c4083f0e756753dcb31ecaab566..aa9caf34bb683ad043b2c875fbd9b58bea12a7db 100644

--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.h

+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.h

@@ -68,7 +68,7 @@ class CONTENT_EXPORT ScreenOrientationDispatcher :

// pointer in the sense that it will destroy it when Remove() will be called.

// Furthermore, we only expect to have one callback at a time in this map,

// which is what IDMap was designed for.

- typedef IDMap<blink::WebLockOrientationCallback, IDMapOwnPointer> CallbackMap;

+ using CallbackMap = IDMap<std::unique_ptr<blink::WebLockOrientationCallback>>;

CallbackMap pending_callbacks_;

ScreenOrientationAssociatedPtr screen_orientation_;

« no previous file with comments | « content/renderer/renderer_blink_platform_impl.h ('k') | content/renderer/service_worker/embedded_worker_dispatcher.h » ('j') | no next file with comments »