content/renderer/push_messaging/push_messaging_dispatcher.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/push_messaging/push_messaging_dispatcher.h

diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h

index 5287c3d9cdc33a572ee299aa0aa5e5c470b8f766..57f6854de788bc4a437f3de520d6a713d6a648d9 100644

--- a/content/renderer/push_messaging/push_messaging_dispatcher.h

+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h

@@ -73,7 +73,7 @@ class PushMessagingDispatcher : public RenderFrameObserver,

void OnSubscribeFromDocumentError(int32_t request_id,

PushRegistrationStatus status);

- IDMap<blink::WebPushSubscriptionCallbacks, IDMapOwnPointer>

+ IDMap<std::unique_ptr<blink::WebPushSubscriptionCallbacks>>

subscription_callbacks_;

DISALLOW_COPY_AND_ASSIGN(PushMessagingDispatcher);