content/renderer/p2p/socket_dispatcher.cc - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/socket_dispatcher.cc

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/p2p/socket_dispatcher.cc

diff --git a/content/renderer/p2p/socket_dispatcher.cc b/content/renderer/p2p/socket_dispatcher.cc

index 4a3c5809aa095409a0d74150eaaab94a58ec27a3..bff5b9a47e334fa11ea95c582a9d607481e078c0 100644

--- a/content/renderer/p2p/socket_dispatcher.cc

+++ b/content/renderer/p2p/socket_dispatcher.cc

@@ -27,7 +27,7 @@ P2PSocketDispatcher::P2PSocketDispatcher(

P2PSocketDispatcher::~P2PSocketDispatcher() {

network_list_observers_->AssertEmpty();

- for (IDMap<P2PSocketClientImpl>::iterator i(&clients_); !i.IsAtEnd();

+ for (IDMap<P2PSocketClientImpl*>::iterator i(&clients_); !i.IsAtEnd();

i.Advance()) {

i.GetCurrentValue()->Detach();

}