content/renderer/media/audio_input_message_filter.cc - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_input_message_filter.cc

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/audio_input_message_filter.cc

diff --git a/content/renderer/media/audio_input_message_filter.cc b/content/renderer/media/audio_input_message_filter.cc

index 744af5785205f08313c0a02c747d97919080ad5f..ff24d7017357148be78b5c001c5fca437efe575c 100644

--- a/content/renderer/media/audio_input_message_filter.cc

+++ b/content/renderer/media/audio_input_message_filter.cc

@@ -114,7 +114,7 @@ void AudioInputMessageFilter::OnChannelClosing() {

DLOG_IF(WARNING, !delegates_.IsEmpty())

<< "Not all audio devices have been closed.";

- IDMap<media::AudioInputIPCDelegate>::iterator it(&delegates_);

+ IDMap<media::AudioInputIPCDelegate*>::iterator it(&delegates_);

while (!it.IsAtEnd()) {

it.GetCurrentValue()->OnIPCClosed();

delegates_.Remove(it.GetCurrentKey());