content/browser/renderer_host/render_process_host_impl.cc - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 597e977a184e46bb5ce9597fa8a5e3160a2c6c61..caabfd0dd885623eb4e242ad469c1e0a4d972ade 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -314,7 +314,7 @@ bool has_done_stun_trials = false;

#endif

// the global list of all renderer processes

-base::LazyInstance<IDMap<RenderProcessHost>>::Leaky g_all_hosts =

+base::LazyInstance<IDMap<RenderProcessHost*>>::Leaky g_all_hosts =

LAZY_INSTANCE_INITIALIZER;

// Map of site to process, to ensure we only have one RenderProcessHost per

@@ -2678,7 +2678,7 @@ void RenderProcessHostImpl::ProcessDied(bool already_dead,

RemoveUserData(kSessionStorageHolderKey);

- IDMap<IPC::Listener>::iterator iter(&listeners_);

+ IDMap<IPC::Listener*>::iterator iter(&listeners_);

while (!iter.IsAtEnd()) {

iter.GetCurrentValue()->OnMessageReceived(FrameHostMsg_RenderProcessGone(

iter.GetCurrentKey(), static_cast<int>(status), exit_code));