chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

index 858affa78e97664438d37905726347e98c44f486..9e01c694f384e78db6ca60ea2b3caad4c35a206f 100644

--- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

+++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

@@ -142,7 +142,7 @@ size_t PopupBlockerTabHelper::GetBlockedPopupsCount() const {

PopupBlockerTabHelper::PopupIdMap

PopupBlockerTabHelper::GetBlockedPopupRequests() {

PopupIdMap result;

- for (IDMap<BlockedRequest, IDMapOwnPointer>::const_iterator iter(

+ for (IDMap<std::unique_ptr<BlockedRequest>>::const_iterator iter(

&blocked_popups_);

!iter.IsAtEnd();

iter.Advance()) {