storage/browser/fileapi/file_system_operation_runner.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/file_system_operation_runner.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/fileapi/file_system_operation_runner.h

diff --git a/storage/browser/fileapi/file_system_operation_runner.h b/storage/browser/fileapi/file_system_operation_runner.h

index a59058a0946a28a3e605f3f977192e8c87301480..dc9a81f2b4380887ecda3d6193c16de87578385a 100644

--- a/storage/browser/fileapi/file_system_operation_runner.h

+++ b/storage/browser/fileapi/file_system_operation_runner.h

@@ -307,8 +307,8 @@ class STORAGE_EXPORT FileSystemOperationRunner

// Not owned; file_system_context owns this.

FileSystemContext* file_system_context_;

- // IDMap<FileSystemOperation, IDMapOwnPointer> operations_;

- IDMap<FileSystemOperation, IDMapOwnPointer> operations_;

+ // IDMap<std::unique_ptr<FileSystemOperation>> operations_;

+ IDMap<std::unique_ptr<FileSystemOperation>> operations_;

// We keep track of the file to be modified by each operation so that

// we can notify observers when we're done.