components/drive/job_scheduler.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/drive/job_scheduler.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/drive/job_scheduler.h

diff --git a/components/drive/job_scheduler.h b/components/drive/job_scheduler.h

index 35f26b4b0fc0f35ec435b811f3d29c3a2defe967..c2e8bd3d5381228c1ea215e3f13fc0d358f2d182 100644

--- a/components/drive/job_scheduler.h

+++ b/components/drive/job_scheduler.h

@@ -382,7 +382,7 @@ class JobScheduler

std::unique_ptr<JobQueue> queue_[NUM_QUEUES];

// The list of queued job info indexed by job IDs.

- typedef IDMap<JobEntry, IDMapOwnPointer> JobIDMap;

+ typedef IDMap<std::unique_ptr<JobEntry>> JobIDMap;

danakj 2016/11/30 23:02:21 s/typedef/using/ while you're here?

JobIDMap job_map_;

// The list of observers for the scheduler.