chrome/browser/permissions/permission_manager.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_manager.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_manager.h

diff --git a/chrome/browser/permissions/permission_manager.h b/chrome/browser/permissions/permission_manager.h

index f6b4f92e997c68be57bd977c90f7070edd5e2b4c..bd90dcf2c4d76dc00eecdd0c435dcbf87793409e 100644

--- a/chrome/browser/permissions/permission_manager.h

+++ b/chrome/browser/permissions/permission_manager.h

@@ -75,10 +75,10 @@ class PermissionManager : public KeyedService,

friend class MediaPermission;

class PendingRequest;

- using PendingRequestsMap = IDMap<PendingRequest, IDMapOwnPointer>;

+ using PendingRequestsMap = IDMap<std::unique_ptr<PendingRequest>>;

struct Subscription;

- using SubscriptionsMap = IDMap<Subscription, IDMapOwnPointer>;

+ using SubscriptionsMap = IDMap<std::unique_ptr<Subscription>>;

PermissionContextBase* GetPermissionContext(content::PermissionType type);