android_webview/native/aw_contents_client_bridge.cc - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_client_bridge.cc

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_contents_client_bridge.cc

diff --git a/android_webview/native/aw_contents_client_bridge.cc b/android_webview/native/aw_contents_client_bridge.cc

index a89e969f9af5a46e3863b5f3b5517c72b5041671..c3c2c0bf2c9b23766ac01528055ddf4626748769 100644

--- a/android_webview/native/aw_contents_client_bridge.cc

+++ b/android_webview/native/aw_contents_client_bridge.cc

@@ -73,7 +73,7 @@ AwContentsClientBridge::~AwContentsClientBridge() {

Java_AwContentsClientBridge_setNativeContentsClientBridge(env, obj, 0);

}

- for (IDMap<content::ClientCertificateDelegate>::iterator iter(

+ for (IDMap<content::ClientCertificateDelegate*>::iterator iter(

&pending_client_cert_request_delegates_);

!iter.IsAtEnd(); iter.Advance()) {

delete iter.GetCurrentValue();