Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)
Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 1150 matching lines...) Expand 10 before | Expand all | Expand 10 after
1161 // (WebKit-originated) context menu events will have an ID of 0 and will not 1161 // (WebKit-originated) context menu events will have an ID of 0 and will not
1162 // be in this map. 1162 // be in this map.
1163 // 1163 //
1164 // We don't want to add internal ones since some of the "special" page 1164 // We don't want to add internal ones since some of the "special" page
1165 // handlers in the browser process just ignore the context menu requests so 1165 // handlers in the browser process just ignore the context menu requests so
1166 // avoid showing context menus, and so this will cause right clicks to leak 1166 // avoid showing context menus, and so this will cause right clicks to leak
1167 // entries in this map. Most users of the custom context menu (e.g. Pepper 1167 // entries in this map. Most users of the custom context menu (e.g. Pepper
1168 // plugins) are normally only on "regular" pages and the regular pages will 1168 // plugins) are normally only on "regular" pages and the regular pages will
1169 // always respond properly to the request, so we don't have to worry so 1169 // always respond properly to the request, so we don't have to worry so
1170 // much about leaks. 1170 // much about leaks.
1171 IDMap<ContextMenuClient, IDMapExternalPointer> pending_context_menus_; 1171 IDMap<ContextMenuClient*> pending_context_menus_;
1172 1172
1173 // The text selection the last time DidChangeSelection got called. May contain 1173 // The text selection the last time DidChangeSelection got called. May contain
1174 // additional characters before and after the selected text, for IMEs. The 1174 // additional characters before and after the selected text, for IMEs. The
1175 // portion of this string that is the actual selected text starts at index 1175 // portion of this string that is the actual selected text starts at index
1176 // |selection_range_.GetMin() - selection_text_offset_| and has length 1176 // |selection_range_.GetMin() - selection_text_offset_| and has length
1177 // |selection_range_.length()|. 1177 // |selection_range_.length()|.
1178 base::string16 selection_text_; 1178 base::string16 selection_text_;
1179 // The offset corresponding to the start of |selection_text_| in the document. 1179 // The offset corresponding to the start of |selection_text_| in the document.
1180 size_t selection_text_offset_; 1180 size_t selection_text_offset_;
1181 // Range over the document corresponding to the actual selected text (which 1181 // Range over the document corresponding to the actual selected text (which
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 bool browser_side_navigation_pending_ = false; 1342 bool browser_side_navigation_pending_ = false;
1343 1343
1344 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1344 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1345 1345
1346 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1346 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1347 }; 1347 };
1348 1348
1349 } // namespace content 1349 } // namespace content
1350 1350
1351 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1351 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/push_messaging/push_messaging_dispatcher.h ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698