chrome/browser/android/service_tab_launcher.h - Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/service_tab_launcher.h

Issue 2496653002: Part 2 of base::IDMap refactor to eliminate IDMapOwnPointer/IDMapExternalPointer modes (Closed)

Patch Set: typedefs => using statements, update comments in base/id_map.h Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_ANDROID_CHROME_SERVICE_TAB_LAUNCHER_H_	5 #ifndef CHROME_BROWSER_ANDROID_CHROME_SERVICE_TAB_LAUNCHER_H_

6 #define CHROME_BROWSER_ANDROID_CHROME_SERVICE_TAB_LAUNCHER_H_	6 #define CHROME_BROWSER_ANDROID_CHROME_SERVICE_TAB_LAUNCHER_H_

7	7

8 #include "base/android/jni_android.h"	8 #include "base/android/jni_android.h"

9 #include "base/callback_forward.h"	9 #include "base/callback_forward.h"

10 #include "base/id_map.h"	10 #include "base/id_map.h"

(...skipping 30 matching lines...) Expand all Loading...
41 void OnTabLaunched(int request_id, content::WebContents* web_contents);	41 void OnTabLaunched(int request_id, content::WebContents* web_contents);

42	42

43 static bool Register(JNIEnv* env);	43 static bool Register(JNIEnv* env);

44	44

45 private:	45 private:

46 friend struct base::DefaultSingletonTraits<ServiceTabLauncher>;	46 friend struct base::DefaultSingletonTraits<ServiceTabLauncher>;

47	47

48 ServiceTabLauncher();	48 ServiceTabLauncher();

49 ~ServiceTabLauncher();	49 ~ServiceTabLauncher();

50	50

51 IDMap<TabLaunchedCallback, IDMapOwnPointer> tab_launched_callbacks_;	51 IDMap<std::unique_ptr<TabLaunchedCallback>> tab_launched_callbacks_;

52	52

53 DISALLOW_COPY_AND_ASSIGN(ServiceTabLauncher);	53 DISALLOW_COPY_AND_ASSIGN(ServiceTabLauncher);

54 };	54 };

55	55

56 #endif // CHROME_BROWSER_ANDROID_CHROME_SERVICE_TAB_LAUNCHER_H_	56 #endif // CHROME_BROWSER_ANDROID_CHROME_SERVICE_TAB_LAUNCHER_H_

OLD	NEW