ui/views/controls/scrollbar/base_scroll_bar.cc - Issue 2496643002: Implement Sebastien's overlay scrollbars for native UI (Views).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/scrollbar/base_scroll_bar.cc

Issue 2496643002: Implement Sebastien's overlay scrollbars for native UI (Views). (Closed)

Patch Set: clarify comment Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/scrollbar/base_scroll_bar.cc

diff --git a/ui/views/controls/scrollbar/base_scroll_bar.cc b/ui/views/controls/scrollbar/base_scroll_bar.cc

index 82d852944b656dadf77f632a2663201039b3eb64..d395f00858dfb0dfa047731c6bbc2abbecbfedad 100644

--- a/ui/views/controls/scrollbar/base_scroll_bar.cc

+++ b/ui/views/controls/scrollbar/base_scroll_bar.cc

@@ -407,8 +407,7 @@ void BaseScrollBar::Update(int viewport_size,

// content size multiplied by the height of the thumb track.

double ratio =

std::min(1.0, static_cast<double>(viewport_size) / contents_size_);

- int thumb_size = static_cast<int>(ratio * GetTrackSize());

- thumb_->SetSize(thumb_size);

+ thumb_->SetLength(static_cast<int>(ratio * GetTrackSize()));

int thumb_position = CalculateThumbPosition(contents_scroll_offset);

thumb_->SetPosition(thumb_position);