Revert of RenderWidget: hoist synchronous IPC out of Init methods.

Revert of RenderWidget: hoist synchronous IPC out of Init methods. (patchset #7 id:120001 of https://codereview.chromium.org/2483593002/ )

Reason for revert:
Well, this is dcheck'ing all over the place, congrats :).

Any number of builders are failing as a result, so I'm reverting this.

See https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/5832 for the main waterfall builder's failures.

Original issue's description:
> RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of Init methods.
>
> RenderWidget now requires two Init phases that are always called, and always in this order:
>  - InitRoutingID (formerly SetRoutingID)
>  - Init (formerly DoInit).
>
> Two distinct Init phases are needed to solve an ordering problem in RenderView.
>
> Instead of Init being parameterized on a callback to allocate a
> route ID, just do the IPC outside of Init, and pass the result in.
>
> BUG=627852
>
> Committed: https://crrev.com/ab31e24367180e818edd6065f8b43277d99e6944
> Cr-Commit-Position: refs/heads/master@{#431386}

TBR=jcivelli@chromium.org,lfg@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627852
Committed: https://crrev.com/7e80889b2b60079c4ddc70d5c527110057a16753
Cr-Commit-Position: refs/heads/master@{#431411}

[Dirk Pranke, 2016-11-11 00:30:09]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-11-11 00:30:10]

Created Revert of RenderWidget: hoist synchronous IPC out of Init methods.

[commit-bot: I haz the power, 2016-11-11 00:30:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 00:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 00:32:56]

Failed to apply patch for content/renderer/render_view_impl.cc:
While running git apply --index -3 -p1;
  error: patch failed: content/renderer/render_view_impl.cc:697
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: content/renderer/render_view_impl.cc: patch does not apply

Patch:       content/renderer/render_view_impl.cc
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc
b/content/renderer/render_view_impl.cc
index
ebdb7894f52162ccf6f769396589b1997cedeaf0..14a3e97ea2d7698f053d971bfdde86b86d814da8
100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -697,20 +697,21 @@
 
 void RenderViewImpl::Initialize(const mojom::CreateViewParams& params,
                                 bool was_created_by_renderer) {
-  RenderWidget::InitRoutingID(params.view_id);
-
-  int opener_view_routing_id = MSG_ROUTING_NONE;
+  SetRoutingID(params.view_id);
+
+  int opener_view_routing_id;
   WebFrame* opener_frame = RenderFrameImpl::ResolveOpener(
       params.opener_frame_route_id, &opener_view_routing_id);
-  if (!was_created_by_renderer)
-    opener_view_routing_id = MSG_ROUTING_NONE;
+  if (opener_view_routing_id != MSG_ROUTING_NONE && was_created_by_renderer)
+    opener_id_ = opener_view_routing_id;
 
   display_mode_ = params.initial_size.display_mode;
 
   webview_ =
       WebView::create(this, is_hidden() ? blink::WebPageVisibilityStateHidden
                                         :
blink::WebPageVisibilityStateVisible);
-  RenderWidget::Init(opener_view_routing_id, webview_->widget());
+  RenderWidget::DoInit(MSG_ROUTING_NONE, webview_->widget(),
+                       CreateWidgetCallback());
 
   g_view_map.Get().insert(std::make_pair(webview(), this));
   g_routing_id_view_map.Get().insert(std::make_pair(GetRoutingID(), this));
@@ -2174,8 +2175,6 @@
 }
 
 int RenderViewImpl::GetRoutingID() const {
-  DCHECK_NE(routing_id(), MSG_ROUTING_NONE)
-      << "Tried to obtain routing ID before it was set.";
   return routing_id();
 }

[commit-bot: I haz the power, 2016-11-11 00:35:11]

Description was changed from

==========
Revert of RenderWidget: hoist synchronous IPC out of Init methods. (patchset #7
id:120001 of https://codereview.chromium.org/2483593002/ )

Reason for revert:
Well, this is dcheck'ing all over the place, congrats :).

Any number of builders are failing as a result, so I'm reverting this.

See
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
for the main waterfall builder's failures.

Original issue's description:
> RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of
Init methods.
> 
> RenderWidget now requires two Init phases that are always called, and always
in this order:
>  - InitRoutingID (formerly SetRoutingID)
>  - Init (formerly DoInit).
> 
> Two distinct Init phases are needed to solve an ordering problem in
RenderView.
> 
> Instead of Init being parameterized on a callback to allocate a
> route ID, just do the IPC outside of Init, and pass the result in.
> 
> BUG=627852
> 
> Committed: https://crrev.com/ab31e24367180e818edd6065f8b43277d99e6944
> Cr-Commit-Position: refs/heads/master@{#431386}

TBR=jcivelli@chromium.org,lfg@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627852
==========

to

==========
Revert of RenderWidget: hoist synchronous IPC out of Init methods. (patchset #7
id:120001 of https://codereview.chromium.org/2483593002/ )

Reason for revert:
Well, this is dcheck'ing all over the place, congrats :).

Any number of builders are failing as a result, so I'm reverting this.

See
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
for the main waterfall builder's failures.

Original issue's description:
> RenderWidget: hoist synchronous IPC (needed to allocate routing IDs) out of
Init methods.
>
> RenderWidget now requires two Init phases that are always called, and always
in this order:
>  - InitRoutingID (formerly SetRoutingID)
>  - Init (formerly DoInit).
>
> Two distinct Init phases are needed to solve an ordering problem in
RenderView.
>
> Instead of Init being parameterized on a callback to allocate a
> route ID, just do the IPC outside of Init, and pass the result in.
>
> BUG=627852
>
> Committed: https://crrev.com/ab31e24367180e818edd6065f8b43277d99e6944
> Cr-Commit-Position: refs/heads/master@{#431386}

TBR=jcivelli@chromium.org,lfg@chromium.org,nick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627852

Committed: https://crrev.com/7e80889b2b60079c4ddc70d5c527110057a16753
Cr-Commit-Position: refs/heads/master@{#431411}
==========

[commit-bot: I haz the power, 2016-11-11 00:35:12]

Patchset 1 (id:??) landed as
https://crrev.com/7e80889b2b60079c4ddc70d5c527110057a16753
Cr-Commit-Position: refs/heads/master@{#431411}