content/renderer/render_view_impl.cc - Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 2496593002: Adding an experimental flag to block autoplay with sound in cross-origin iframes (Closed)

Patch Set: falling back to adding a boolean flag Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 0c11c301552002fbe814cde77704144a6c9b6e31..b0b6b472134c128bea2b1639219be05e8d024685 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1028,7 +1028,10 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,

base::SysInfo::IsLowEndDevice();

// TODO(mlamouri): rename this setting "isLowEndDevice".

settings->setForcePreloadNoneForMediaElements(is_low_end_device);

-#endif

+#else // defined(OS_ANDROID)

+ settings->setCrossOriginMediaPlaybackRequiresUserGesture(

+ prefs.cross_origin_media_playback_requires_user_gesture);

+#endif // defined(OS_ANDROID)

settings->setAutoplayExperimentMode(

blink::WebString::fromUTF8(prefs.autoplay_experiment_mode));